Issue reporter fails to report when sandbox is enabled
#157368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super confusing, it seems properties have to go through an update call? For example restricted mode is not passed in initially but then here: vscode/src/vs/code/electron-sandbox/issue/issueReporterMain.ts Lines 1151 to 1153 in a77af4b Who came up with this 😱 |
|
Looks like some relative recent change in #154209, @TylerLeonhardt can you explain the reasoning? |
bpasero
changed the title
sandbox is enabled
|
I'm not sure what the reasoning is as this pattern existed before I owned the issue reporter. Since the issue reporter has been going through many discussions about its future, I didn't want to make any large refactoring changes so I followed the existing patterns (even though they are confusing) in order to unblock someone. |
|
Any objections with my approach? |
TylerLeonhardt
approved these changes
Aug 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not really understand how the issue reporter was working so far, but it looks like all of the
IssueReporterDatais not stored into theIssueReporterModelso I would assume many of the properties in an issue are actually wrong, for example restricted mode, etc.I only noticed this because my new property
isSandboxedwas not working.@TylerLeonhardt maybe you have an idea or overview why the issue reporter is broken like this?